golangci-lint: enable it for all issues not just new

[mstoykov]

What?

Just call golangci-lint over the whole project not just the "new" parts.

Why?

As now all lint issues are fixed we can enable without that option.

Unfortunately the option only looks at code at and around the places that was changed and if any of it has new lint errors it will trigger.

That does mean that if you update golangci-lint - it won't showcase new lint errors it triggers.

Also won't work if you add a bunch of code to the end an already somewhat long function. As the lint error will be at the beginning of the function.

Checklist

• I have performed a self-review of my code.
• I have added tests for my changes.
• I have run linter locally (make lint) and all checks pass.
• I have run tests locally (make tests) and all tests pass.
• I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#769

[olegbespalov]

🤞

[olegbespalov]

As part of this PR, we might consider adding (increasing default) timeout option, see https://github.com/grafana/k6/actions/runs/8831719518/job/24247507781?pr=3713

run golangci-lint
  Running [/home/runner/golangci-lint-1.57.2-linux-amd64/golangci-lint run --out-format=github-actions --config=/home/runner/work/k6/k6/./.github/actions/lint//.golangci.yml] in [] ...
  level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
  
  Error: golangci-lint exit with code 4

I believe this could happen more often if we increase the scope of scanning 🤔

[mstoykov]

It has been happening for a while now.

We can do it, but I expect that this chanage actaully makes this checks faster as actually they have to do less work.

Again it runs all the linters, just then skips any report that isn't on lines that are in hte "diff"/"patch" that is between the current code and the previous version that is given.