Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/grafana/xk6-webcrypto to v0.3.0 #3713

Closed
wants to merge 1 commit into from

Conversation

olegbespalov
Copy link
Collaborator

@olegbespalov olegbespalov commented Apr 25, 2024

What?

This brings the latest updates of webcrypto including changes from release https://github.com/grafana/xk6-webcrypto/releases/tag/v0.3.0

Why?

We'd like to include the updates in the upcoming release.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov added documentation-needed A PR which will need a separate PR for documentation dependencies Pull requests that update a dependency file labels Apr 25, 2024
@olegbespalov olegbespalov added this to the v0.51.0 milestone Apr 25, 2024
@olegbespalov olegbespalov self-assigned this Apr 25, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner April 25, 2024 11:27
@olegbespalov olegbespalov requested review from mstoykov and joanlopez and removed request for a team April 25, 2024 11:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.24%. Comparing base (eec9105) to head (0e8ca27).

❗ Current head 0e8ca27 differs from pull request most recent head c9bf94b. Consider uploading reports for the commit c9bf94b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3713      +/-   ##
==========================================
- Coverage   73.26%   73.24%   -0.03%     
==========================================
  Files         276      276              
  Lines       20420    20420              
==========================================
- Hits        14961    14956       -5     
- Misses       4504     4507       +3     
- Partials      955      957       +2     
Flag Coverage Δ
ubuntu 73.24% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov
Copy link
Collaborator

Nice 450kb saved:

55556   k6-master
55108   k6-webcrypto

@olegbespalov
Copy link
Collaborator Author

Closing in favor of #3714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation-needed A PR which will need a separate PR for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants