Add async api breaking change notice to release notes #3721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
reviewed
Apr 29, 2024
release notes/v0.51.0.md
Outdated
Comment on lines
9
to
12
| - `#pr`, `<small_break_1>` | ||
| - `#pr`, `<small_break_2>` | ||
| ### Browser APIs to Async | ||
|
|
||
| ### (_optional h3_) `<big_breaking_change>` `#pr` |
There was a problem hiding this comment.
Do not drop the placeholders, please
There was a problem hiding this comment.
I've added them back in 9d9e50b
codebien
reviewed
Apr 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.51.0 #3721 +/- ##
==================================================
Coverage ? 73.59%
==================================================
Files ? 277
Lines ? 20247
Branches ? 0
==================================================
Hits ? 14900
Misses ? 4399
Partials ? 948
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
ankur22
force-pushed
the
add/async-api-release-notes-2
branch
from
0c463ec
to
2fc5840
Compare
inancgumus
approved these changes
Apr 29, 2024
codebien
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adding the async api breaking change notice to release notes
Why?
We need to inform as many of our users of this large breaking change so that that they are ready for it.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)