-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes: Browser async Tap
#3723
Conversation
36d1ce7
to
031c176
Compare
5400463
to
031c176
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.51.0 #3723 +/- ##
==================================================
Coverage ? 73.52%
==================================================
Files ? 275
Lines ? 20242
Branches ? 0
==================================================
Hits ? 14882
Misses ? 4406
Partials ? 954
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
031c176
to
d77e14d
Compare
- [`frame.tap`](https://grafana.com/docs/k6/latest/javascript-api/k6-experimental/browser/frame/) | ||
- [`elementHandle.tap`](https://grafana.com/docs/k6/latest/javascript-api/k6-experimental/browser/elementhandle/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update these links once I update the documentation. I'm doing my best, but let's be ready (and merge this release notes PR first) since k6 wants to release this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Either I can or if you don't mind doing it, could the Browser APIs to Async be amended to mention this breaking change?
Something like "We have migrated a single API (tap
), which you can find below that will help visualize the upcoming breaking change"
d77e14d
to
fe1bf87
Compare
Good idea! What do you think about this? fe1bf87 Update: Update: |
670facb
to
995bcc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What?
Add a breaking-change note for the async
Tap
method.Why?
The
Tap
method is converted from sync to async.Related PR(s)/Issue(s)
Updates: grafana/xk6-browser#1251