Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase golang ci lint timeout #3725

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

mstoykov
Copy link
Collaborator

@mstoykov mstoykov commented Apr 29, 2024

What?

Golangci-lint config fixes.

deadline was renamed to timeout ... long time ago.

And config verificaiton showed more settings that were no longer available and were removed.

Why?

The ci keeps timing out - so lets actually configure it correctly.

Cleaning up the config along the way.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added the ci label Apr 29, 2024
@mstoykov mstoykov added this to the v0.51.0 milestone Apr 29, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 29, 2024 14:18
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team April 29, 2024 14:18
@mstoykov mstoykov merged commit ace4bb4 into master Apr 29, 2024
22 checks passed
@mstoykov mstoykov deleted the increaseGolangCILintTimeout branch April 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants