Fix: archive config option #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
+ Coverage 62.69% 62.69% +<.01%
==========================================
Files 95 95
Lines 6956 6957 +1
==========================================
+ Hits 4361 4362 +1
Misses 2348 2348
Partials 247 247
Continue to review full report at Codecov.
|
robingustafsson
requested changes
Mar 6, 2018
| @@ -97,5 +98,6 @@ func init() { | |||
| archiveCmd.Flags().SortFlags = false | |||
| archiveCmd.Flags().AddFlagSet(optionFlagSet()) | |||
| archiveCmd.Flags().AddFlagSet(runtimeOptionFlagSet(false)) | |||
| archiveCmd.Flags().AddFlagSet(configFlagSet()) | |||
There was a problem hiding this comment.
@ppcano We need to refactor configFlagSet as it would otherwise introduces CLI flags for archive that are nonsensical (--linger, --out, --no-usage-report, --no-thresholds).
|
This one can be closed since it was superseded by the now merged PR #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #519