Turn off clustering for log gathering alloy #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the primary alloy, which does use clustering. Also add some instructions for setting the storage path for logs instance Signed-off-by: Pete Wall <pete.wall@grafana.com>
This was
linked to
issues
Apr 17, 2024
thampiotr
approved these changes
Apr 18, 2024
| */}} | ||
| {{ fail "Invalid configuration for gathering pod logs! When using logs.pod_logs.gatherMethod: \"volumes\", Grafana Alloy for Logs should not utilize clustering. Otherwise, performance will suffer!\nPlease set:\nalloy-logs:\n alloy:\n clustering:\n enabled: false"}} | ||
| {{- end }} | ||
|
|
||
| {{- else if eq .Values.logs.pod_logs.gatherMethod "api" }} | ||
| {{- if not (index .Values "alloy-logs").alloy.clustering.enabled }} | ||
| {{- if eq (index .Values "alloy-logs").controller.type "daemonset" }} |
There was a problem hiding this comment.
Logs via k8s API can be collected with a deployment or statefulset, a daemonset ties the number of instances to number of nodes, which is not necessary. Technically this is not wrong though.
Comment on lines
+55
to
+65
| enableStatefulSetAutoDeletePVC: true | ||
| volumeClaimTemplates: | ||
| - metadata: | ||
| name: alloy-log-positions | ||
| spec: | ||
| accessModes: ["ReadWriteOnce"] | ||
| storageClassName: "standard" | ||
| resources: | ||
| requests: | ||
| storage: 100Mi |
There was a problem hiding this comment.
Looks good, just that we haven't been running it this way, so not much experience on our side.
skl
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move PodLogs control to the primary alloy, which does use clustering.
Also add some instructions for setting the storage path for logs instance.