MetricNamesStore doesn't properly initialize

[bwangfdu]

I find the 3.0.1 version not working when there is an variable in Grafana template when using metrics() as query. It reports "Template variables could not be initialized: Cannot read property 'regexp' of undefined" if I use metrics() and reports "Template variables could not be initialized: Cannot read property 'then' of undefined" if I use metrics(myprefix).
After debugging with Chrome, I find MetricNamesStore.initialize():Promise<string[]> is never called in page load, and when calling get(): Promise<string[]>, the initialized property is false and fetchingPromise is undefined. After an explicit calling initialize(), using metrics(myprefix) is recovered. But metrics() still no luck.

This is my fixed get():

public get(): Promise<string[]> {
        if (this.initialized) {
            return this.promiseUtils.resolvedPromise(this.metricNames);
        } else {
            return this.initialize();
        }
    }

[jifwin]

Thanks for reporting that. I refactored that a bit into a single function. Fixed on master (3.0.2)

[bwangfdu]

'Thank you very much.

On Mon, Jul 2, 2018 at 1:43 PM Grzegorz ***@***.***> wrote: Thanks for reporting that. I refactored that a bit into a single function. Fixed on master (3.0.2) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJrcwhPbH_1f5WzTR_vnC-e1bUlRDMAKks5uCoXjgaJpZM4U_2UX> .

-- Best, Bin