This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
adding support for expansion of templated multi-select metrics #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are probably better ways to accomplish this. But this works.
The problem this solves is that with this plugin, templated values for metrics don't work when multi-select or "all" option is specified.
For example, if I create a template var
$metrics = metrics(kairosdb.jvm)
, and click the box for "Multi Value" or "Allow All Option", then the metrics aren't resolved. It tries to run a query with a metric like this:which obviously doesn't work.
This patch expands that template-replaced grafana metric into multiple kairosdb metrics in the query, so that each can be calculated and then graphed