Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

adding support for expansion of templated multi-select metrics #23

Closed
wants to merge 1 commit into from

Conversation

davejhilton
Copy link

@davejhilton davejhilton commented Jul 11, 2016

There are probably better ways to accomplish this. But this works.

The problem this solves is that with this plugin, templated values for metrics don't work when multi-select or "all" option is specified.

For example, if I create a template var $metrics = metrics(kairosdb.jvm), and click the box for "Multi Value" or "Allow All Option", then the metrics aren't resolved. It tries to run a query with a metric like this:

{kairosdb.jvm.free_memory,kairosdb.jvm.max_memory,kairosdb.total_memory}

which obviously doesn't work.

This patch expands that template-replaced grafana metric into multiple kairosdb metrics in the query, so that each can be calculated and then graphed

@vjkoskela vjkoskela mentioned this pull request Jul 11, 2016
@davejhilton
Copy link
Author

Closing, since #18 has been adapted to cover this case (and far better than this hack 😱 )

@davejhilton davejhilton deleted the templatedMetrics branch October 1, 2016 01:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant