This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Grafana 4 cosmetic adaptations + config panel #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jifwin
suggested changes
Jan 30, 2017
| @@ -0,0 +1,16 @@ | |||
| /// <reference path="/usr/share/grafana/public/app/headers/common.d.ts" /> | |||
There was a problem hiding this comment.
This should definitely be a relative path. Is it really needed? Actually I made it work without imports and reference. Please remove those.
There was a problem hiding this comment.
I'm going to clean this up myself in seperate branch. Thank you.
|
Thank you for this PR, it makes good progress in UI. However it still needs some polish. PRs welcomed :). |
This was referenced Jan 30, 2017
Closed
jifwin
approved these changes
Feb 6, 2017
|
sorry did not have much time to look at it. Great you did the cleanup. I'll test the new branch and check what's not working |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.