This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Alias fix by replace #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trl.js to make downsampling none when creating a new dashboard
…and dateMath.parse was no longer working. Fix is in the datasource.js file.
…-zmon/kairosdb-datasource into zalando-zmon-remove-downsampling-option
…v.replace() until no '$' in tar
…loop If templateSrv does not find the variable to replace, it 'might' return $ which causes infinite loop. Use replaceCount to limit to at most 10 replacement.
all urls are stores in jsonData.urls which can be found in instanceSettings in the datasource.js. Use urls only when multi mode is turn on.
… with grafana type look into example of graphite https://github.com/grafana/grafana/blob/master/public/app/plugins/datasource/graphite/config_ctrl.ts , and find that datasourceSrv can use loadDatasource which returns backendSrv (might have a better way to just import but currently do not know how to), and use $http from backendSrv to get all datasources list, and filter to only store kairosdatasource in jsonData.allKarirosDatasource.
…atasource instead of backendSrv Realized that datasourceSrv has more general functionality then backendSrv which is during construction
…rrors
Check Inspect Nectwork to see ossibly unhandled rejection:
{"err":{"data":null,"status":-1,"config":{"method":"POST","transformRequest":[null],"transformResponse":[null],"jsonpCallbackParam":"callback","url":"api/datasources/proxy/19/api/v1/datapoints/query/tags","requestId":"1.kairosdb.http.ingest_time.host.metricKeyValueLookup","data":{"metrics":[{"name":"kairosdb.http.ingest_time"}],"cache_time":0,"start_absolute":0},"retry":0,"timeout":{},"headers":{"X-Grafana-Org-Id":1,"Accept":"application/json,
text/plain,
*/*","Content-Type":"application/json;charset=utf-8"}},"statusText":""},"cancelled":true}
…est during DS construction, thr
datasourceRequest are using a specific requestId to track either to cancel request or not. Use unique datasource ID to make each request unique.
… _performMetricSuggestQuery
…g arrow for functions, change v
…on for all lodash each function
Ewocker
force-pushed
the
aliasFixByReplace
branch
from
a4a04b2
to
7145cb6
Compare
Ewocker
force-pushed
the
aliasFixByReplace
branch
2 times, most recently
from
9133d7a
to
11f0046
Compare
|
This has been completely refactored in v3.0.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not branch of from aliasFix branch but instead branch of from master.
The fix includes 2 commits:
Execute templateSrv.replace() until no '$' in target (here refers to alias string) is found
Instead of using while loop, use for loop with limited count (10 times) to prevent unpredictable loop caused by templateSrc.replace.