This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Aggregator autovalue and remove aggregator fix #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trl.js to make downsampling none when creating a new dashboard
…and dateMath.parse was no longer working. Fix is in the datasource.js file.
…-zmon/kairosdb-datasource into zalando-zmon-remove-downsampling-option
…v.replace() until no '$' in tar
…loop If templateSrv does not find the variable to replace, it 'might' return $ which causes infinite loop. Use replaceCount to limit to at most 10 replacement.
all urls are stores in jsonData.urls which can be found in instanceSettings in the datasource.js. Use urls only when multi mode is turn on.
… with grafana type look into example of graphite https://github.com/grafana/grafana/blob/master/public/app/plugins/datasource/graphite/config_ctrl.ts , and find that datasourceSrv can use loadDatasource which returns backendSrv (might have a better way to just import but currently do not know how to), and use $http from backendSrv to get all datasources list, and filter to only store kairosdatasource in jsonData.allKarirosDatasource.
…atasource instead of backendSrv Realized that datasourceSrv has more general functionality then backendSrv which is during construction
…rrors
Check Inspect Nectwork to see ossibly unhandled rejection:
{"err":{"data":null,"status":-1,"config":{"method":"POST","transformRequest":[null],"transformResponse":[null],"jsonpCallbackParam":"callback","url":"api/datasources/proxy/19/api/v1/datapoints/query/tags","requestId":"1.kairosdb.http.ingest_time.host.metricKeyValueLookup","data":{"metrics":[{"name":"kairosdb.http.ingest_time"}],"cache_time":0,"start_absolute":0},"retry":0,"timeout":{},"headers":{"X-Grafana-Org-Id":1,"Accept":"application/json,
text/plain,
*/*","Content-Type":"application/json;charset=utf-8"}},"statusText":""},"cancelled":true}
…est during DS construction, thr
datasourceRequest are using a specific requestId to track either to cancel request or not. Use unique datasource ID to make each request unique.
… _performMetricSuggestQuery
Merging second pull request from Yu-An: Alias fix by replace plus master
…ster Revert "Alias fix by replace plus master"
…-templating branch from github/grafana/kairosdb-datasource repo.
…er than using a separate drop down for the value and the unit.
…arameter_converter.
…the format is no longer different.
…the format is no longer different.
…the format is no longer different.
…the format is no longer different.
…r percentile converter.
…s used in their expression.
…ery() was called.
…but there are data points without the tag value. The UI would not let you select the tag. This was also confusing for a single valued tag because it looked (from the UI) like the tag value was selected when in fact it was not.
If you add 2 or more aggregators to a Grafana panel, delete the first, the other will show it as having the interval and alignment from the first aggregator rather than the one you just entered. The fix is to directly call the getVisibleParameters() method from the controller. I believe this was not working because the UI was not refreshing the controller state ($scope.apply() not being called). Also, fixed autoValue to correctly set the sampling unit. I probably broke this in my last set of changes.
|
I did not do this correctly. Closing the pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add 2 or more aggregators to a Grafana panel, delete the first, the other will show having the interval and alignment from the first aggregator rather than the one you just entered.
The fix is to directly call the getVisibleParameters() method from the controller. I believe this was not working because the UI was not refreshing the controller state ($scope.apply() not being called).
Also, fixed autoValue to correctly set the sampling unit.