Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

implement testDatasource function #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sspieker
Copy link

This PR adds a testDatasource() function, following the documentation for datasource plugins at Datasource development. It queries the health endpoint of KairosDB and returns the http status code.

This fixes 2 situations:

  1. the misleading error message when clicking on "save & test" in the datasource configuration
  2. the new Grafana 6 feature which does not allow a KairosDB datasource to be selected if the health check fails

BrandonArp added a commit to ArpNetworking/kairosdb-datasource that referenced this pull request Apr 19, 2019
@sspieker
Copy link
Author

@jifwin @marefr , sorry to bother you but you're the persons who did the last commits in this repository. Could you please take a look at this? With this quite simple PR KairosDB becomes functional in Grafana 6 again.

@djzort
Copy link

djzort commented Jun 12, 2020

you might consider also pushing to https://github.com/kairosdb/kairosdb-datasource

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants