Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Revert "Add EnsureNoExportedKindName check" #13

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

undef1nd
Copy link
Contributor

Reverts this commit 0aae354

@sdboyer and I concluded that the check is too restrictive and does not add value, given that the Go compiler itself is enough to spot when the the CUE field name generates a Go type shadowing the package name.
Besides, both the generated types naming rule may change in the future.

@undef1nd undef1nd requested a review from sdboyer April 28, 2023 11:13
Copy link
Contributor

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! it's a shame because this provided us a baseline for what i expect will be a validation pattern we'll want to follow in kindsys. But we'll get there :)

@sdboyer sdboyer merged commit 1439291 into main Apr 28, 2023
@sdboyer sdboyer deleted the revert-check branch April 28, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants