Remove redundant field prefixes from PanelCfg interface #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dprokop would love to get your sign-off that this is what you had in mind @ryantxu any concerns with dropping these prefixes? see grafana/grafana#64723 (comment) |
frossano-grafana
requested review from
spinillos,
joanlopez,
Clarity-89,
AgnesToulet and
malcolmholmes
joanlopez
approved these changes
Apr 18, 2023
Definitely, otherwise it'll be unsafe to update kindsys. Need to coordinate those PRs @Duologic @malcolmholmes fyi, this will echo directly through to all of our grok codegen. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
Requires a bunch of updates in grafana/grafana and grafana/grok.
Fixes #6