Add EnsureNoExportedKindName check

[undef1nd]

Issue: in some cases using Kind as a schema field name leads to generating Kind type in Go that shadows existing type in that same package in Grafana.

Related to https://github.com/grafana/schematization-and-as-code-project/issues/31

[sdboyer]

I tried to call it in LoadCoreKindDef but vk.Source() there returns nil, so not possible to use it there.

The vk there is the root node of the whole kind. Gotta walk down to the schema elements, first.

Though, looking now, i realize this is awkward because LoadCoreKindDef() doesn't actually call thema.BindLineage(), so you can't do something like this, where thema makes it easy to get at the cue.Value for each schema:

	for sch := lin.First(); sch != nil; sch = sch.Successor() {
		if err := validation.EnsureNoExportedKindName(sch.Underlying()); err == nil {
			return err
		}
	}

Hmmm. Maybe that means it's best done here, instead. That feels to me like it's too late...but for now it's probably the most convenient spot.

[undef1nd]

The vk there is the root node of the whole kind. Gotta walk down to the schema elements, first

That should be probably fine, as I search for the lineage node first here. And then search for the keyword in the lineage node elements.

[sdboyer]

This approach looks good to me 👍🏻

Next question is where we hook in to apply it!

[undef1nd]

Next question is where we hook in to apply it!

As we discussed in the chat, put it here in Grafana https://github.com/grafana/grafana/pull/66516/files

[sdboyer]

i think this should be good to mark as ready so that we can get it merged and progress on the other PR

[joanlopez]

I really like this approach, very clean and reusable! Great! 🚀

PS: Thinking out loud -- Could we add a unit test? It may also help understanding how to use the function from the consumer perspective.

[sdboyer]

Thinking out loud -- Could we add a unit test?

IMO definitely worth doing. It'll necessarily also be tested on our corpus once we have one, but it deserves a smaller unit test too

[sdboyer]

LGTM, too!