Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include instance type in list output #2

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Include instance type in list output #2

merged 1 commit into from
Dec 19, 2022

Conversation

inkel
Copy link
Collaborator

@inkel inkel commented Dec 19, 2022

Closes #1

@inkel
Include instance type in list output
941c7b0 
Closes #1

Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
@inkel inkel requested a review from jvrplmlmn December 19, 2022 14:34
@inkel inkel self-assigned this Dec 19, 2022
jvrplmlmn
jvrplmlmn approved these changes Dec 19, 2022
View reviewed changes
Copy link

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on GCP, AWS and Azure 👍

@inkel inkel merged commit 66069ed into main Dec 19, 2022
@inkel inkel deleted the list/instance-type branch December 19, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvrplmlmn jvrplmlmn jvrplmlmn approved these changes

Assignees

@inkel inkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend kubectl nodepools list to display the instance type of the node pool
2 participants
@inkel @jvrplmlmn