Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages to their latest versions and improve test #5

Merged
merged 3 commits into from
Mar 13, 2020

Conversation

ghimire
Copy link
Contributor

@ghimire ghimire commented Mar 12, 2020

In this PR:

  • Update go packages to their latest versions
  • Run go mod tiny
  • Add missing EOL
  • Improve tests:
    • To ensure k3d is running
    • To ensure kubeconfig is available

@joe-elliott
Copy link
Member

What does go.mod look like if you run go mod tidy ? I think most of those deps would disappear.

Is there a particular reason to update the dependencies? Is there a bug fix or feature you're trying to capture?

Ensure k3d is running.
Ensure kubeconfig is available.
@ghimire ghimire changed the title Update packages to their latest versions Update packages to their latest versions and improve test Mar 13, 2020
@ghimire
Copy link
Contributor Author

ghimire commented Mar 13, 2020

@joe-elliott I have updated this PR with the result of go mod tidy after your suggestion. In some cases while building the docker image after running go build on host, the build was failing. On clean cloned repository this wasn't the case. So I can't say there are any particular reasons to update the dependencies other than the usual benefits of having latest code.

I have since updated the test to ensure k3d is running and kubeconfig are available before kubernetes-diff-logger binary is run. On several occasions, either of those conditions failed before the executable was run and it would fail. This is no longer happening with these improvements.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@joe-elliott joe-elliott merged commit a8a9f73 into grafana:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants