Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: improve logging #2

Merged
merged 7 commits into from
Jan 13, 2022
Merged

Chore: improve logging #2

merged 7 commits into from
Jan 13, 2022

Conversation

leventebalogh
Copy link
Contributor

What changed?

  • added an .nvmrc as well to show the recommended Node.js version, just in case someone is using NVM
  • changed the progress logging to be debug messages (they can be a bit noisy in case there are a lot of imports)
  • added a very simple summary message (which we probably should improve in the future)

@leventebalogh leventebalogh added the enhancement New feature or request label Jan 13, 2022
@leventebalogh leventebalogh self-assigned this Jan 13, 2022
jackw
jackw approved these changes Jan 13, 2022
View reviewed changes
Copy link

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 🚀

@leventebalogh leventebalogh merged commit 7e329ff into main Jan 13, 2022
@leventebalogh leventebalogh deleted the leventebalogh/fix-logging branch January 13, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@mckn mckn Awaiting requested review from mckn

Assignees

@leventebalogh leventebalogh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leventebalogh @jackw