-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logql: Fix grammar for String
#14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the package-lock.json is mandatory. The rest is looking good.
@@ -1,6 +1,6 @@ | |||
# lezer-logql | |||
|
|||
LogQL lezer grammar based on https://github.com/grafana/loki/blob/main/pkg/logql/expr.y. | |||
LogQL lezer grammar based on https://github.com/grafana/loki/blob/main/pkg/logql/syntax/expr.y. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch! 🤩
Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently our grammar has incorrectly matched string in 3 cases:
'
. This is not valid in LogQL."
didn't have closing"
(more info: https://discuss.codemirror.net/t/trying-to-understand-lezer-grammar-for-string/2264)We are fixing this in this PR and adding tests.