Grammar: Add DurationVariable
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cool - let us discuss in tomorrow's standup if we wait for @ivanahuckova / @gabor or not. |
|
I am worried here a little, because we are tying/inter-connecting grafana's variables with logql grammar. I would rather try to solve this in grafana repo as this is open source package that can possibly be used in other projects where this can potentially create issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in this issue grafana/grafana#54448 we are facing problems when parsing queries with errors. With the lezer-common update, lezer will not stop parsing until a known element is found or the end of the string.
When parsing an empty stream selector
{}followed by an unknown duration[$__interval]this resulted in unwanted behavior - e.g. when adding ad-hoc queries.To overcome this for now, I added
$__intervaland$__interval_msas known elements to the parser named asDurationVariable.