Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogRangeExpr: Fix incorrect offset node #30

Merged
merged 3 commits into from
Jul 7, 2023
Merged

LogRangeExpr: Fix incorrect offset node #30

merged 3 commits into from
Jul 7, 2023

Conversation

gwdawson
Copy link
Member

@gwdawson gwdawson commented Jul 6, 2023

replace Offset with OffsetExpr.
lezer was expecting the wrong node therefore throwing errors with valid queries.

Before & After:

Screenshot 2023-07-06 at 10 55 48 Screenshot 2023-07-06 at 10 56 19

@gwdawson gwdawson added the bug Something isn't working label Jul 6, 2023
@gwdawson gwdawson requested a review from a team July 6, 2023 10:03
@gwdawson gwdawson self-assigned this Jul 6, 2023
svennergr
svennergr reviewed Jul 6, 2023
View reviewed changes
package.json Show resolved Hide resolved
src/logql.grammar Show resolved Hide resolved
@gwdawson gwdawson requested a review from svennergr July 6, 2023 15:25
svennergr
svennergr approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@svennergr svennergr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gwdawson gwdawson merged commit 492878d into main Jul 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svennergr svennergr svennergr approved these changes

Assignees

@gwdawson gwdawson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwdawson @svennergr