-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix npm publish workflow #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still is not going to work. I'd recommend that you test it in the console before.
I'll recommend something shortly. |
There's another thing that I don't like, which is that we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try the following:
- Go to publish-npm.yml
- replace
yarn
withnpm instal --ignore-scripts
- replace
yarn build
withnpm run build
Btw, github actions can be tested with https://github.com/nektos/act |
due to an oversight on my behalf, (#34) didn't actually fix the issue.
as you can see from the demo, without the second half of the script, if husky doesn't exist it still throws an error making the workflow fail. however, with the second half, if husky doesn't exist the command just runs
echo
and doesn't errorgithub is now throwing errors whilst trying to upload the demo (linked in slack thread):
https://raintank-corp.slack.com/archives/C03PMJLVC67/p1689594553023209?thread_ts=1689588697.351199&cid=C03PMJLVC67