Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prepare script with postinstall #38

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

gwdawson
Copy link
Member

@gwdawson gwdawson commented Jul 18, 2023

first we merge #37 to revert back to 0.1.6, we then merge this that will build and release to 0.1.7

the issue we had was prepare we being called in the background of npm publish... this was then making the workflow fail because husky was not installed.

this changes the script to postinstall that still runs after npn install but doesnt get triggerd in the build and publish workflow

https://docs.npmjs.com/cli/v9/using-npm/scripts#npm-install

@gwdawson gwdawson changed the title Replace preaper script with postinstall Replace prepare script with postinstall Jul 18, 2023
@gwdawson gwdawson self-assigned this Jul 18, 2023
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@gwdawson gwdawson merged commit 6fc0f62 into main Jul 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants