Logfmt: add support for new structure and new features (flags, arguments) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point. I thought about this and I would lean into a major version if I was asked, due to the amount of breaking changes. BUT. We're the only users AFAIK, so I'm also not sure if it's worth overthinking it. |
matyax
changed the title
Definitely should have been a major version increase. |
|
Ready to revert the revert. |
ivanahuckova
approved these changes
Sep 5, 2023
|
Even though our current CHANGELOG.md is not great, do you mind adding a new entry there? |
|
Updated, let me know what you think @svennergr |
That's great - thank you! |
ivanahuckova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #54
Adds this back. We shouldn't merge yet because we should figure out if this shouldn't be a major version increase?