Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogQL: add sort and sort_desc support #56

Merged
merged 2 commits into from
Oct 17, 2023
Merged

LogQL: add sort and sort_desc support #56

merged 2 commits into from
Oct 17, 2023

Conversation

matyax
Copy link
Contributor

@matyax matyax commented Oct 17, 2023

Adding support to sort and sort_desc for proper query handling, validation, and syntax highlighting.

Reference: https://github.com/grafana/loki/blob/main/pkg/logql/syntax/expr.y

LogQL part of grafana/grafana#70882

Trees before:

Before 1

Before 2

Trees after:

After 2

After 1

Copy link

@gtk-grafana gtk-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matyax matyax merged commit ecd10ab into main Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants