IP filter: Add tests #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw the PR and, without looking at the repo, I suspected the issue was related with Lezer. |
matyax
approved these changes
Feb 13, 2024
I'll add context in the next PR! Just wanted to make it clear that refactor/update won't affect the current behavior and will fix issue when "ip" is in stream selector (which works in Loki, compared to for example |
|
100% clear. I've just been suspecting that having something with the string "ip" in the stream selector could be causing troubles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that currently there are no tests for IP filter. In the next PR I am going to do a slight refactor to IP filter, so before doing so, I wanted to add tests to make it easier to review.