Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: exports must declare types for moduleresolution: bundler #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jackw
Copy link

@jackw jackw commented Mar 6, 2024

Please don't merge / release this until I've verifed this change doesn't break other tsconfig moduleresolution settings.

Packages that declare themselves as ES modules ("type": "module" in package.json) that also include an exports property must declare a types property otherwise Typescript cannot find the types when typescripts "moduleResolution": "bundler" is set.

image

@jackw jackw added the bug Something isn't working label Mar 6, 2024
@jackw jackw self-assigned this Mar 6, 2024
@jackw jackw changed the title Fix: exports must declare types for ESM environments Fix: exports must declare types for moduleresolution: bundler Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant