Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump lezer #8

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Chore: Bump lezer #8

merged 2 commits into from
Jul 11, 2022

Conversation

zoltanbedi
Copy link
Member

@zoltanbedi zoltanbedi commented Jun 17, 2022

Please take care of releasing this if you find it useful.

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zoltanbedi!

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I've found out that tree viz is not working with this change. +cc @gabor

"@lezer/lr": "https://unpkg.com/@lezer/lr@0.15.8/dist/index.js",
"@lezer/common": "https://unpkg.com/@lezer/common@0.15.11/dist/index.js"
"@grafana/lezer-logql": "https://unpkg.com/@grafana/lezer-logql@0.0.13/index.es.js",
"@lezer/lr": "https://unpkg.com/@lezer/lr@1.0.0/dist/index.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this @lezer/lr": "https://unpkg.com/@lezer/lr@1.0.0/dist/index.js specific change breaks the tree viz tool. It gives module import failed. this requires a browser with import map support.. The issue is present from @lezer/lr@16.0.0 and 15.8 is the last working version for this.
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it shouldn't until we release this.

@ivanahuckova ivanahuckova self-requested a review June 20, 2022 08:39
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabor not sure if for the browser tool it make sense to have different version for now and create issue in their repo?

@zoltanbedi zoltanbedi merged commit 2e157bb into main Jul 11, 2022
@gabor
Copy link
Contributor

gabor commented Jul 11, 2022

@ivanahuckova hmm.. i'll look into this problem, but i think for now we can merge this, we can fix the tree-viz.html problem in a separate pull request somehow.

@zoltanbedi zoltanbedi deleted the upgrade-lezer branch July 11, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants