Don't make a nested if, break out early if no tenant configsZ

grafana · Jun 20, 2024 · 6b6d3d6 · 6b6d3d6
1 parent 07a82f0
commit 6b6d3d6
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/pkg/ingester/stream.go b/pkg/ingester/stream.go
@@ -369,16 +369,18 @@ func (s *stream) storeEntries(ctx context.Context, entries []logproto.Entry, usa
 }
 
 func (s *stream) handleLoggingOfDuplicateEntry(entry logproto.Entry) {
-	if s.configs != nil {
-		if s.configs.LogDuplicateMetrics(s.tenant) {
-			s.metrics.duplicateLogBytesTotal.WithLabelValues(s.tenant).Add(float64(len(entry.Line)))
-		}
-		if s.configs.LogDuplicateStreamInfo(s.tenant) {
-			errMsg := fmt.Sprintf("duplicate log entry at timestamp %s for stream %s", entry.Timestamp.Format(time.RFC3339), s.labelsString)
-			dupErr := errors.New(errMsg)
-			s.writeFailures.Log(s.tenant, dupErr)
-		}
+	if s.configs == nil {
+		return
 	}
+	if s.configs.LogDuplicateMetrics(s.tenant) {
+		s.metrics.duplicateLogBytesTotal.WithLabelValues(s.tenant).Add(float64(len(entry.Line)))
+	}
+	if s.configs.LogDuplicateStreamInfo(s.tenant) {
+		errMsg := fmt.Sprintf("duplicate log entry at timestamp %s for stream %s", entry.Timestamp.Format(time.RFC3339), s.labelsString)
+		dupErr := errors.New(errMsg)
+		s.writeFailures.Log(s.tenant, dupErr)
+	}
+
 }
 
 func (s *stream) validateEntries(ctx context.Context, entries []logproto.Entry, isReplay, rateLimitWholeStream bool, usageTracker push.UsageTracker) ([]logproto.Entry, []entryWithError) {