Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route params in /loki/api/v1/label/<name>/values are tracked verbatim in request telemetry #11549

Closed
dannykopping opened this issue Dec 26, 2023 · 0 comments · Fixed by #11551
Closed

Route params in /loki/api/v1/label/<name>/values are tracked verbatim in request telemetry #11549

dannykopping opened this issue Dec 26, 2023 · 0 comments · Fixed by #11551
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! type/bug Somehing is not working as expected

Comments

@dannykopping
Copy link
Contributor

The /loki/api/v1/label/<name>/values endpoint accepts a path parameter, and this is used in the route label of the loki_request_duration_seconds_{bucket,sum,count} metrics. This type of reflected user input is both dangerous and unnecessary as a label.

Describe the bug
The given route input should not be reflected in the telemetry of the requests.

Expected behavior
The /loki/api/v1/label/<name>/values is rendered as loki_api_v1_label_values without the user input.
@dannykopping dannykopping added good first issue These are great first issues. If you are looking for a place to start, start here! type/bug Somehing is not working as expected labels Dec 26, 2023
dannykopping pushed a commit to dannykopping/loki that referenced this issue Dec 27, 2023
Do not reflect label names in request metrics' "route" label
a97f688 
Fixes grafana#11549

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping mentioned this issue Dec 27, 2023
Merged
8 tasks
dannykopping pushed a commit that referenced this issue Dec 27, 2023
Do not reflect label names in request metrics' "route" label (#11551)
18ea388 
**Which issue(s) this PR fixes**:
Fixes #11549
dannykopping pushed a commit to dannykopping/loki that referenced this issue Dec 27, 2023
Do not reflect label names in request metrics' "route" label (grafana…
71028c3 
…#11551)

**Which issue(s) this PR fixes**:
Fixes grafana#11549
dannykopping pushed a commit to dannykopping/loki that referenced this issue Feb 19, 2024
Do not reflect label names in request metrics' "route" label (grafana…
c79cd9b 
…#11551)

**Which issue(s) this PR fixes**:
Fixes grafana#11549

(cherry picked from commit 18ea388)
dannykopping pushed a commit to dannykopping/loki that referenced this issue Feb 20, 2024
Do not reflect label names in request metrics' "route" label (grafana…
609f5ea 
…#11551)

**Which issue(s) this PR fixes**:
Fixes grafana#11549

(cherry picked from commit 18ea388)
dannykopping pushed a commit to dannykopping/loki that referenced this issue Feb 26, 2024
Do not reflect label names in request metrics' "route" label (grafana…
f0f79a3 
…#11551)

**Which issue(s) this PR fixes**:
Fixes grafana#11549

(cherry picked from commit 18ea388)
rhnasc pushed a commit to inloco/loki that referenced this issue Apr 12, 2024
@rhnasc
Do not reflect label names in request metrics' "route" label (grafana…
19444cc 
…#11551)

**Which issue(s) this PR fixes**:
Fixes grafana#11549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These are great first issues. If you are looking for a place to start, start here! type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not reflect label names in request metrics' "route" label dannykopping/loki
1 participant
@dannykopping