Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix parsing of default per tenant otlp config #12836

Merged
merged 1 commit into from
May 14, 2024

Conversation

sandeepsukhani
Copy link
Contributor

@sandeepsukhani sandeepsukhani commented Apr 30, 2024

What this PR does / why we need it:
There was a mistake I made in setting the default per tenant otlp config parsed from the overall Loki config, which causes Loki to ignore it. The per tenant otlp config set in overrides works as expected.
This PR fixes the issue and updates the otlp integration test to validate the change.

Which issue(s) this PR fixes:
Fixes #12780

Checklist

  • Tests updated

@sandeepsukhani sandeepsukhani requested a review from a team as a code owner April 30, 2024 12:15
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sandeepsukhani sandeepsukhani merged commit 7cc9a93 into main May 14, 2024
60 checks passed
@sandeepsukhani sandeepsukhani deleted the otlp-fix-global-otlp-tenant-config branch May 14, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlp_config has no effect
2 participants