fix: Redo ingester profile tagging #13239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pr reverts 00d3c7a and takes a different approach to adding profile tagging.
Previously we were using the
pprof.Do
method which internal does this:To make this pattern work we had to wrap a lot of business logic and change error handling within many of the ingester functions, this unfortunately introduced a few bugs and made the code more brittle.
This PR instead uses the same mechanisms in the
Do
method directly in the various ingester methods, which should hopefully be a lot less error prone and invasive.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR is two commits, the first is a revert for 00d3c7a and the second is a re-implementation using the new method, it's probably a lot easier to review this PR by looking at just the second commit
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR