Loki returns an entire table on query with negative limit value.

[Estrax]

Describe the bug
When querying Loki with a query parameter limit: -1 (or any other negative value), Loki returns an entire table. When doing it from Grafana, it crashes a browser thread when the returned object is too big (because parsing takes too long or we exceed a memory limit).

Expected behavior
With negative limit parameter Loki returns no elements.

[adityacs]

@cyriltovena This is already fixed here #1470
@Estrax Which version of loki you are using?

Example

curl 'http://localhost:3100/loki/api/v1/query_range?direction=BACKWARD&end=1581911056457208000&limit=-1&query=%7Bfilename%3D%22%2Fvar%2Flog%2Fsystem.log%22%7D&start=1581695056457208000'
rpc error: code = Code(400) desc = limit must be a positive value

[Estrax]

@adityacs always the current master :) this particular thing was noticed in 1.3.0. We already took care of that on a Grafana side, I just pointed it out that it might be worth checking on a Loki side again.

[adityacs]

@Estrax Sorry for the delayed reply. I tested this on 6.6.0 Grafana with 1.3.0 Loki. It returns the expected error