Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live tailing sends duplicate logs #931

Closed
slim-bean opened this issue Aug 21, 2019 · 4 comments
Closed

Live tailing sends duplicate logs #931

slim-bean opened this issue Aug 21, 2019 · 4 comments
Labels
keepalive An issue or PR that will be kept alive and never marked as stale. type/bug Somehing is not working as expected

Comments

@slim-bean
Copy link
Collaborator

Describe the bug
When connected over the websocket you can/will receive duplicate logs (same labels, same message)

Expected behavior
Ideally we would not send duplicate logs

@stale
Copy link

stale bot commented Sep 20, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 20, 2019
@stale stale bot closed this as completed Sep 27, 2019
@cyriltovena cyriltovena added the keepalive An issue or PR that will be kept alive and never marked as stale. label Nov 12, 2019
@cyriltovena cyriltovena reopened this Nov 12, 2019
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Nov 12, 2019
@aocenas
Copy link
Member

aocenas commented Nov 13, 2019

@cyriltovena Based on our yesterday discussion I understand that this is not really fixable short term and client should either deduplicate itself or use the delay_for.

@slim-bean
Copy link
Collaborator Author

Closing this issue, it's always going to be difficult to remove all duplicates when using replication, the delay_for paramater can help but if you want your logs super fast you may get dupes.

@josh-ross-ai
Copy link

Closing this issue, it's always going to be difficult to remove all duplicates when using replication, the delay_for paramater can help but if you want your logs super fast you may get dupes.

When you say "using replication", do you mean within the promtail config? Or loki? Also, I am seeing what I think is a similar issue, however, the duplicate logs are coming from promtail agents running on different nodes. Was that the problem you were having @slim-bean ?

@chaudum chaudum added the type/bug Somehing is not working as expected label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive An issue or PR that will be kept alive and never marked as stale. type/bug Somehing is not working as expected
Projects
None yet
Development

No branches or pull requests

5 participants