Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #9510 introduces an additional IPv6 listener in gateway which breaks on systems without IPv6 support #9681

Closed
tjuerge opened this issue Jun 12, 2023 · 3 comments · Fixed by #11722
Labels
area/helm type/bug Somehing is not working as expected

Comments

@tjuerge
Copy link

tjuerge commented Jun 12, 2023

Describe the bug
PR #9510 introduces an additional IPv6 listener in gateway which fails on systems with single-stack setup (IPv4 only):

nginx: [emerg] socket() :8080 failed (97: Address family not supported by protocol)

Btw. in the Helm charts of Tempo and Mimir is IPv6 not activated by default (yet).

To Reproduce
Steps to reproduce the behavior:

  1. Deploy Loki with Helm chart version 5.5.10+ on a IPv4-only system
  2. Check gateway log

Expected behavior
Loki's gateway should run on a IPv4-only system like it does before Helm chart version 5.5.10.

Environment:

  • Infrastructure: Kubernetes 1.26.5 (single-stack -> no IPv6)
  • Deployment tool: Helm chart grafana/loki v5.5.10+

Screenshots, Promtail config, or terminal output
Gateway / Nginx log:

nginx: [emerg] socket() :8080 failed (97: Address family not supported by protocol)
@chaudum chaudum added kind/bug area/helm type/bug Somehing is not working as expected and removed kind/bug labels Jun 14, 2023
@ssams
Copy link

ssams commented Aug 24, 2023

just ran into this issue, using the Helm chart grafana/loki v5.15.0.

In case it helps others with this problem, I'm currently using the following workaround which attempts to keep as much as possible from the original values to simplify updates in the meantime. Use as values when deploying:

gateway:
  nginxConfig:
    file: |
      {{- include "loki.nginxFile" . | replace "listen             [::]:8080;" "" | indent 2 -}}

@bimax
Copy link

bimax commented Nov 27, 2023

Does anyone know if this is going to be added as values config option? Maybe there are pull request somewhere in the repo?

@Pionerd
Copy link
Contributor

Pionerd commented Jan 19, 2024

Created a PR to make this configurable in a bit nicer way: #11722

MichelHollands added a commit that referenced this issue Jan 22, 2024
**What this PR does / why we need it**: Loki Gateway pod crashes on
systems that only have IPv4 enabled since PR
#9510

**Which issue(s) this PR fixes**:
Fixes #9681

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [ ] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e)
- [x] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](0d4416a)

---------

Signed-off-by: Pieter van der Giessen <pieter@pionative.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
rhnasc pushed a commit to inloco/loki that referenced this issue Apr 12, 2024
**What this PR does / why we need it**: Loki Gateway pod crashes on
systems that only have IPv4 enabled since PR
grafana#9510

**Which issue(s) this PR fixes**:
Fixes grafana#9681

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [ ] Tests updated
- [x] `CHANGELOG.md` updated
- [x] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@d10549e)
- [x] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](grafana@0d4416a)

---------

Signed-off-by: Pieter van der Giessen <pieter@pionative.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants