promtail: fix externalURL and path prefix issues #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, check the CI please, you have issues compiling |
erwinvaneyk
force-pushed
the
fix-path-prefix
branch
from
9f05c3e
to
b004de5
Compare
|
Whoops, thanks @sh0rez 🙂 |
|
Awesome thank you for this |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the UI of promtail breaks when it is exposed on a subpath. I found and resolved two issues:
Both ExternalURL and PathPrefix need to be set to expose it on a subpath. PathPrefix configures the mux, and ExternalURL is used to configure the urls in the templates. I added line 53 ensure that users only need to set the ExternalURL.
The root redirects directly to
/targetsand does not account for the path prefix. This PR adds the path prefix to this redirect.As a flyby, I replaced the background contexts with the context present in the HTTP request.