Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Thanos objstore, dskit and other modules #10366

Merged
merged 12 commits into from Aug 28, 2023
Merged

Upgrade Thanos objstore, dskit and other modules #10366

merged 12 commits into from Aug 28, 2023

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Aug 28, 2023 •
edited

What this PR does / why we need it:
Upgrades various common modules including dskit, thanos objstore, prometheus, etc. Fixes errors/ changes resulting due to module upgrades.

This is required in order to eventually upgrade BEL dependency in GEL to point to master.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@shantanualsi shantanualsi marked this pull request as ready for review August 28, 2023 07:09
@shantanualsi shantanualsi requested a review from a team as a code owner August 28, 2023 07:09
@shantanualsi shantanualsi changed the title Upgrade Thanos objstore Upgrade Thanos objstore, prometheus, dskit and other modules Aug 28, 2023
@shantanualsi shantanualsi changed the title Upgrade Thanos objstore, prometheus, dskit and other modules Upgrade Thanos objstore, dskit and other modules Aug 28, 2023
ashwanthgoli
ashwanthgoli reviewed Aug 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ashwanthgoli
ashwanthgoli approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ashwanthgoli ashwanthgoli merged commit 586b904 into main Aug 28, 2023
4 checks passed
@ashwanthgoli ashwanthgoli deleted the shantanu/upgrade-thanos-objstore branch August 28, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shantanualsi @ashwanthgoli