Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruler.wal-cleaer.period #10378

Merged
merged 2 commits into from Aug 29, 2023
Merged

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Aug 29, 2023

What this PR does / why we need it:
The config with typo is now replaced by ruler.wal-cleaner.period

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Aug 29, 2023
@shantanualsi shantanualsi marked this pull request as ready for review August 29, 2023 09:25
@shantanualsi shantanualsi requested a review from a team as a code owner August 29, 2023 09:25
The config with typo is now replaced by ruler.wal-cleaner.period
@shantanualsi shantanualsi force-pushed the cleanup-campsite/remove-wal-cleaer-period branch from 33160f8 to 199110d Compare August 29, 2023 13:44
@chaudum chaudum merged commit 92ba055 into main Aug 29, 2023
5 checks passed
@chaudum chaudum deleted the cleanup-campsite/remove-wal-cleaer-period branch August 29, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants