lambda-promtail: Add support for WAF logs in S3 #10416
Conversation
|
|
lpugoy
force-pushed
the
lambda_promtail_add_support_waf_logs
branch
from
ee38354
to
77011d1
Compare
|
Used #8254 as a guide which was unfortunately closed without merging. |
To not lose nanosecond precision. Also added comments to the function.
|
@cstyan Thank you for your comments, added commits to address them. |
|
|
||
| fractionalSec := float64(i % sec) | ||
| if fractionalSec == 0 { | ||
| return sec, 0, err |
There was a problem hiding this comment.
I think you want to set an actual value for err here? otherwise it has the nil value from strconv.ParseInt
There was a problem hiding this comment.
Yes, err would be nil if fractionalSec is 0. There would only be an error during parsing, fractionalSec being 0 just means that the Unix time only has seconds resolution. It is not an error.
| @@ -652,64 +682,71 @@ func TestProcessSQSEvent(t *testing.T) { | |||
| require.True(t, handlerCalled) | |||
| } | |||
|
|
|||
| func TestToMicroseconds(t *testing.T) { | |||
| func TestGetUnixSecNsec(t *testing.T) { | |||
There was a problem hiding this comment.
this test needs a case for the fractionalSec == 0 case as well
There was a problem hiding this comment.
This tests fractionalSec == 0.
|
Sorry, just saw a typo in the test; it was referring to the old function name. Pushed a fix. |
**What this PR does / why we need it**: Adds support for WAF logs in S3 in lambda-promtail **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [x] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e)
What this PR does / why we need it:
Adds support for WAF logs in S3 in lambda-promtail
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR