Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade thanos objstore #10451

Merged
merged 3 commits into from Sep 6, 2023
Merged

Upgrade thanos objstore #10451

merged 3 commits into from Sep 6, 2023

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Sep 5, 2023 •
edited

What this PR does / why we need it:

Upgrades Thanos objstore module. This is mostly to keep Loki up to date with the latest modules and also resolves a module conflict while updating cortex-tools.

Which issue(s) this PR fixes:
NA

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@shantanualsi shantanualsi mentioned this pull request Sep 6, 2023
Merged
dannykopping
dannykopping approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shantanualsi shantanualsi marked this pull request as ready for review September 6, 2023 10:21
@shantanualsi shantanualsi requested a review from a team as a code owner September 6, 2023 10:21
@dannykopping dannykopping enabled auto-merge (squash) September 6, 2023 10:22
@dannykopping dannykopping merged commit 97d52d9 into main Sep 6, 2023
4 checks passed
@dannykopping dannykopping deleted the upgrade-objstore branch September 6, 2023 10:37
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@shantanualsi @rhnasc
Upgrade thanos objstore (grafana#10451)
c394aba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannykopping dannykopping dannykopping approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shantanualsi @dannykopping