Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Remove default value of storageClassName in loki/loki helm chart #1058

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Helm: Remove default value of storageClassName in loki/loki helm chart #1058

merged 2 commits into from
Sep 26, 2019

Conversation

polar3130
Copy link
Contributor

What this PR does / why we need it:
This PR fixes that remove default value of storageClassName in loki/loki helm chart, in order to leverage the default storage class feature.

Which issue(s) this PR fixes:
Fixes #1050

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit a2060ef into grafana:master Sep 26, 2019
@polar3130 polar3130 deleted the fix-loki-helm-chart-pv branch September 28, 2019 02:00
@polar3130 polar3130 restored the fix-loki-helm-chart-pv branch September 28, 2019 02:00
@polar3130 polar3130 deleted the fix-loki-helm-chart-pv branch September 28, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[helm] Properly support default storage class
2 participants