Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy ingester shutdown handler #10655

Merged
merged 3 commits into from Sep 21, 2023

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Sep 20, 2023

What this PR does / why we need it:

The handler was deprecated for a while and is removed in favour or /ingester/shutdown?flush=true.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

The handler was deprecated for a while and is removed in favour or
`/ingester/shutdown?flush=true`.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum requested a review from a team as a code owner September 20, 2023 08:03
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Sep 20, 2023
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] LGTM

docs/sources/setup/upgrade/_index.md Outdated Show resolved Hide resolved
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaudum chaudum merged commit e036371 into main Sep 21, 2023
5 checks passed
@chaudum chaudum deleted the chaudum/remove-legacy-shutdown-handler branch September 21, 2023 11:02
chaudum added a commit that referenced this pull request Sep 21, 2023
The reference to a headline on the API page broke, because the headline
was removed in #10655

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum mentioned this pull request Sep 21, 2023
7 tasks
chaudum added a commit that referenced this pull request Sep 21, 2023
The reference to a headline on the API page broke, because the headline was removed in #10655

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
The handler was deprecated for a while and is removed in favour or `/ingester/shutdown?flush=true`.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
The reference to a headline on the API page broke, because the headline was removed in grafana#10655

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants