doc: unify GOPATH

[daixiang0]

All other docs use $GOPATH rather that $(go env GOPATH), unify them.

Signed-off-by: Xiang Dai 764524258@qq.com

[rfratto]

I'm not sure about this. I think $(go env GOPATH) is more guaranteed to work since not everyone sets GOPATH in their environment variables. Maybe we want to change the other references to $(go env GOPATH)?

Thoughts?

[sh0rez]

@rfratto thought of the same, however the following says no:

# run without an environment (env -i)
$ env -i sh

# print env
$ set 
IFS='
'
OPTIND='1'
PATH='/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
PPID='28725'
PS1='$ '
PS2='> '
PS4='+ '
PWD='/home/tbraack/go/src/github.com/grafana/loki'

$ go env GOPATH

$

It looks like contrary to things like GOARCH, go cannot autodetect this and is not smarter than the plain environment variable

[rfratto]

@sh0rez Hmm, I'm experiencing something different:

$ env -i bash
$ go env GOPATH
build cache is required, but could not be located: GOCACHE is not defined and neither $XDG_CACHE_HOME nor $HOME are defined
$ export HOME=/home/robert
$ go env GOPATH           
/home/robert/go

[sh0rez]

Don't use bash, it sources your .bashrc and whatnot again, so your env is not actually clean

[rfratto]

LGTM, let's go with consistency with $GOPATH and the rest of the internet for now.