embedded cache: update metric namespace and remove duplicate metrics #10693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
JStickler
approved these changes
Sep 28, 2023
Comment on lines
+74
to
+77
| - The following embedded cache metrics are removed. Instead use `loki_cache_fetched_keys`, `loki_cache_hits`, `loki_cache_request_duration_seconds` which instruments requests made to the configured cache (`embeddedcache`, `memcached` or `redis`). | ||
| - `querier_cache_added_total` | ||
| - `querier_cache_gets_total` | ||
| - `querier_cache_misses_total` |
There was a problem hiding this comment.
If these are a one-to-one replacement, to avoid confusion I'd list them next to the parameter they're replacing. (If they aren't a one-to-one replacement, then ignore this suggestion!)
Suggested change
| - The following embedded cache metrics are removed. Instead use `loki_cache_fetched_keys`, `loki_cache_hits`, `loki_cache_request_duration_seconds` which instruments requests made to the configured cache (`embeddedcache`, `memcached` or `redis`). | |
| - `querier_cache_added_total` | |
| - `querier_cache_gets_total` | |
| - `querier_cache_misses_total` | |
| - The following embedded cache metrics are removed. Instead use the new metrics, which instrument requests made to the configured cache (`embeddedcache`, `memcached` or `redis`). | |
| - `querier_cache_added_total` instead use `loki_cache_fetched_keys` | |
| - `querier_cache_gets_total` instead use `loki_cache_hits` | |
| - `querier_cache_misses_total` instead use `loki_cache_request_duration_seconds` |
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…rafana#10693) **What this PR does / why we need it**: Removes the following embedded cache metrics since `loki_cache_request_duration_seconds` (which instruments requests made to all the caches) [already covers them](https://github.com/grafana/loki/blob/6a07988491124c91d4acb1cbbf2ee2a4d7dc8900/pkg/storage/chunk/cache/cache.go#L110): - `querier_cache_added_total` - `querier_cache_gets_total` - `querier_cache_misses_total` Updates the namespace and subsystem for the following metrics - `querier_cache_added_new_total` is renamed to `loki_embeddedcache_added_new_total` - `querier_cache_evicted_total` is renamed to `loki_embeddedcache_evicted_total` - `querier_cache_entries` is renamed to `loki_embeddedcache_entries` - `querier_cache_memory_bytes` is renamed to `loki_embeddedcache_memory_bytes` Removes already deprecated metric `querier_cache_stale_gets_total` **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Tests updated - [x] `CHANGELOG.md` updated - [ ] If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [ ] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the following embedded cache metrics since
loki_cache_request_duration_seconds(which instruments requests made to all the caches) already covers them:querier_cache_added_totalquerier_cache_gets_totalquerier_cache_misses_totalUpdates the namespace and subsystem for the following metrics
querier_cache_added_new_totalis renamed toloki_embeddedcache_added_new_totalquerier_cache_evicted_totalis renamed toloki_embeddedcache_evicted_totalquerier_cache_entriesis renamed toloki_embeddedcache_entriesquerier_cache_memory_bytesis renamed toloki_embeddedcache_memory_bytesRemoves already deprecated metric
querier_cache_stale_gets_totalWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR