Do not transfer off chunks on ingester shutdown #10709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Write Ahead Log (WAL) supersedes the chunk transfer feature. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
github-actions
bot
added
the
type/docs
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
|
@salvacorts Can you please add a section in the upgrade notes what to do when you had the chunk transfer enabled (and no WAL)?
|
salvacorts
added a commit
that referenced
this pull request
Oct 11, 2023
Backport be3ca9c from #10850 --- **What this PR does / why we need it**: In #10709, we removed `-ingester.max-transfer-retries` in favor of the WAL. Then, in #10844 we removed it from the config file but we did not remove it from the ingester args. This PR solves this by removing it. Co-authored-by: Salva Corts <salva.corts@grafana.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
This PR removes the ability of an ingester in LEAVING state prior to shutdown to transfer chunks off to another ingester in the ring in PENDING state. The **Write Ahead Log** (WAL) supersedes the chunk transfer feature. See upgrade notes for information how to replace the removed setting. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Salva Corts <salva.corts@grafana.com>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: In grafana#10709, we removed `-ingester.max-transfer-retries` in favor of the WAL. Then, in grafana#10844 we removed it from the config file but we did not remove it from the ingester args. This PR solves this by removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Write Ahead Log (WAL) supersedes the chunk transfer feature.
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR