Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksonnet: generate tsdb_shipper storage_config even if using_boltdb_shipper is false #11195

Merged
merged 5 commits into from Nov 17, 2023

Conversation

Canuteson
Copy link
Contributor

What this PR does / why we need it:
When configuring tsdb shipper without using bolt db shipper, the ksonnet library fails to generate the tsdb_shipper storage config.

Which issue(s) this PR fixes:
Fixes #11194

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Canuteson Canuteson requested a review from a team as a code owner November 9, 2023 18:30
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

Trivy scan found the following vulnerabilities:

@dannykopping dannykopping merged commit 5395c36 into grafana:main Nov 17, 2023
7 checks passed
jeschkies pushed a commit that referenced this pull request Nov 21, 2023
…ipper is false (#11195)

**What this PR does / why we need it**:
When configuring tsdb shipper without using bolt db shipper, the ksonnet
library fails to generate the tsdb_shipper storage config.
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
…ipper is false (grafana#11195)

**What this PR does / why we need it**:
When configuring tsdb shipper without using bolt db shipper, the ksonnet
library fails to generate the tsdb_shipper storage config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsonnet: storage_config clients are not generated when using only tsdb_shipper
4 participants