Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some additional logging to the canary on queries #1137

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Add some additional logging to the canary on queries #1137

merged 3 commits into from
Oct 9, 2019

Conversation

slim-bean
Copy link
Collaborator

No description provided.

@slim-bean
log what was missing from the websocket connection and what we receiv…
e120828 
…ed from a query to Loki to troubleshoot missing logs
@slim-bean slim-bean requested a review from rfratto October 9, 2019 15:29
rfratto
rfratto approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, LGTM

@slim-bean slim-bean merged commit 8a95972 into master Oct 9, 2019
@slim-bean slim-bean deleted the add-canary-debug-logging branch October 9, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slim-bean @rfratto