Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollback fluent-bit push path until we release 0.4 #1155

Merged
merged 1 commit into from
Oct 15, 2019
Merged

rollback fluent-bit push path until we release 0.4 #1155

merged 1 commit into from
Oct 15, 2019

Conversation

cyriltovena
Copy link
Contributor

fixes #1150

@cyriltovena
Copy link
Contributor Author

@slim-bean can we merge that until we get 0.4 released ?

slim-bean
slim-bean approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 8393c33 into grafana:master Oct 15, 2019
rally25rs
rally25rs approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@rally25rs rally25rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for making it a value. Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rally25rs rally25rs rally25rs approved these changes

@slim-bean slim-bean slim-bean approved these changes

Assignees

@slim-bean slim-bean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loki-stack sets the wrong push URL in fluent-bit config
3 participants
@cyriltovena @rally25rs @slim-bean