Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(operator): Add support for Swift TLS CA configuration #11708

Merged
merged 5 commits into from
Apr 19, 2024
Merged

feat(operator): Add support for Swift TLS CA configuration #11708

merged 5 commits into from
Apr 19, 2024

Conversation

btaani
Copy link
Contributor

@btaani btaani commented Jan 18, 2024

What this PR does / why we need it:
With this PR, the LokiStack administrator can supply a ConfigMap in the same namespace that contains Swift object storage CA bundle, which will be mounted as a volume to the loki containers in the statefulset/deployment spec.

Which issue(s) this PR fixes:
Fixes LOG-4820

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@btaani btaani requested review from periklis, xperimental and a team as code owners January 18, 2024 14:13
periklis
periklis reviewed Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena enabled auto-merge (squash) April 19, 2024 08:12
@cyriltovena cyriltovena changed the title operator: Add support for Swift TLS CA configuration fate(operator): Add support for Swift TLS CA configuration Apr 19, 2024
@cyriltovena cyriltovena changed the title fate(operator): Add support for Swift TLS CA configuration feat(operator): Add support for Swift TLS CA configuration Apr 19, 2024
@cyriltovena cyriltovena merged commit c1415c5 into grafana:main Apr 19, 2024
21 of 22 checks passed
btaani added a commit to btaani/loki that referenced this pull request Apr 19, 2024
@btaani
Revert "operator: Add support for Swift TLS CA configuration (grafana…
bb0af3e 
…#11708)"

This reverts commit c1415c5.
@btaani btaani mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis left review comments

@cyriltovena cyriltovena cyriltovena approved these changes

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

Assignees
No one assigned
Labels
sig/operator size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btaani @periklis @cyriltovena